Skip to content

refactor(desktop): lock renderer root architecture - #4088

Open
chihumyum wants to merge 1 commit into
apache:mainfrom
chihumyum:refactor/app-shell-root-foundation
Open

refactor(desktop): lock renderer root architecture#4088
chihumyum wants to merge 1 commit into
apache:mainfrom
chihumyum:refactor/app-shell-root-foundation

Conversation

@chihumyum

@chihumyum chihumyum commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add enforced Desktop renderer ownership zones and a generated AppShell/root debt baseline.
  • Prevent AppShell and root-entry dependency growth while allowing debt to shrink during later slices.
  • Pin the production renderer entry chain from the main process through Vite to main.tsx.
  • Run the architecture check in CI.

Refs #3439

This is the R1 root foundation. It does not move feature ownership out of AppShell or close #3439.

Verification

  • npm run check:renderer-architecture -- --base upstream/main
  • TMPDIR=/private/tmp npm test
  • npm run build
  • npm run typecheck
  • npm run lint
  • npm run format:check

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Codex — implementation and validation.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — CI and builds now reject renderer architecture regressions; runtime product behavior is unchanged.
  • No

@github-actions github-actions Bot added the effort/XL Over 1000 readable lines label Aug 28, 2026
@chihumyum
chihumyum force-pushed the refactor/app-shell-root-foundation branch from af9b950 to df2d6f9 Compare August 28, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/XL Over 1000 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(desktop): make AppShell a renderer composition root

1 participant