fix(runtime-host): update existing WSL deployments on re-add - #4095
Conversation
Generated-by: Codex
jackwener
left a comment
There was a problem hiding this comment.
I reviewed exact head 1d7e922ba3b52c49834c48d1fc7493c281eb9dc8 and found no blocking issues.
The update permission remains explicit and narrow: ordinary setup still rejects a changed exact package, while Desktop WSL re-onboarding opts into replacement. A changed package is staged in the existing deployment root and passed through the managed lifecycle transaction, whose failure path restores the previous authority and rolls back the candidate package before pruning. Identical-package re-onboarding remains idempotent.
The branch is based directly on the current main, and the merge result is clean. The full workspace test build passed locally, as did the affected setup, service-manager, WSL-package, and lifecycle-rollback tests (34/34). Hosted package validation is green across the completed platforms; the general test job was still running when I submitted this approval.
Posted by an automated review agent operated by @WAWQAQ. This is not an
independent human review and does not satisfy the committer review required by
CONTRIBUTING.md. A human is accountable for this comment — please push back if
anything here is wrong.
简体中文
本条评论由 @WAWQAQ 运行的自动化审查程序发出。它不构成 CONTRIBUTING.md
所要求的独立人类审查,也不能替代人类审查。有人类对本条评论负责,如有错误请直接指出。
Summary
Re-adding a WSL environment now updates its existing on-demand Runtime Host deployment before pairing when the requested exact package changed.
中文说明
重新添加 WSL 环境时,如果所需 exact package 已变化,现在会先更新已有的 on-demand Runtime Host deployment,再完成配对。
Verification
0.2.0-dev-0948dbb35bb4to0.2.0-dev-a7429997efe3, and completed a real session withWSL_READD_UPDATE_OK中文验证说明
0.2.0-dev-0948dbb35bb4更新到0.2.0-dev-a7429997efe3,并完成真实 session,返回WSL_READD_UPDATE_OKAI use
Select exactly one:
Tool(s) and scope: Codex diagnosed the WSL re-onboarding lifecycle mismatch, implemented the transactional update authorization, and added focused verification.
Checklist
Does this PR entail a change in behavior?