Skip to content

docs(desktop): record the workbar stories entry - #4104

Merged
Astro-Han merged 1 commit into
mainfrom
docs/workbar-stories-entry
Aug 28, 2026
Merged

docs(desktop): record the workbar stories entry#4104
Astro-Han merged 1 commit into
mainfrom
docs/workbar-stories-entry

Conversation

@Astro-Han

Copy link
Copy Markdown
Contributor

Doc drift left by #4101.

That PR gave Storybook its own features/workbar/stories entry and moved WorkbarSurface out of testing, and taught workbar-boundary.test.ts to accept all three entries — but the feature README still told readers that stories share testing.

This names the three entries and records why the split exists: stories stays out of the production barrel because workbar-host reaches the surface through lazy(), and out of testing because that entry is loaded by node --test against tsc output, while the surface and its tool panels use extensionless relative specifiers only a bundler resolves. Putting it in testing is what broke CI on #4101's first attempt; the README is where the next person should find that out.

Docs only — no code change.

#4101 gave Storybook its own `features/workbar/stories` entry and moved
`WorkbarSurface` there, but the feature README still said stories share
`testing`. Name all three entries and why the split exists, so the next
reader does not re-derive it from `workbar-boundary.test.ts`.

@jackwener jackwener left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found no P0–P3 issues on exact head 994aa9199c10482494046feb591c79aab5ea5e49.

The README now names the three public entries that the code already has: features/workbar, features/workbar/testing, and features/workbar/stories. That matches stories.ts, the production barrel (no WorkbarSurface), workbar-host's lazy(() => import('./workbar-surface')), the Storybook imports, and workbar-boundary.test.ts. testing still does not export the surface. The surface and its panels still use extensionless relative specifiers, so they do not belong on the node --test / tsc path.

Docs only. I am not merging. Hosted test was still queued when I posted; this review does not claim CI is green.


Posted by an automated review agent operated by @WAWQAQ. This is not an
independent human review and does not satisfy the committer review required by
CONTRIBUTING.md. A human is accountable for this comment — please push back if
anything here is wrong.

简体中文

精确 head 994aa9199c10482494046feb591c79aab5ea5e49 上我没有发现 P0–P3。

README 现在写的三个入口和代码一致:生产 barrel、testingstoriesWorkbarSurface 不在生产入口,由 workbar-hostlazy() 加载;Storybook 从 stories 引入;testing 仍不导出它。表面和工具面板仍用无扩展名相对路径,所以不能进 node --test / tsc 那条线。

这是文档修正,我不合入。发这条时 hosted test 还在排队,这次审查不表示 CI 已绿。

本条评论由 @WAWQAQ 运行的自动化审查程序发出。它不构成 CONTRIBUTING.md
所要求的独立人类审查,也不能替代人类审查。有人类对本条评论负责,如有错误请直接指出。

@github-actions github-actions Bot added the effort/XS Under 10 readable lines label Aug 28, 2026
@Astro-Han
Astro-Han merged commit a94d077 into main Aug 28, 2026
2 checks passed
@Astro-Han
Astro-Han deleted the docs/workbar-stories-entry branch August 28, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/XS Under 10 readable lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants