docs(desktop): record the workbar stories entry - #4104
Conversation
#4101 gave Storybook its own `features/workbar/stories` entry and moved `WorkbarSurface` there, but the feature README still said stories share `testing`. Name all three entries and why the split exists, so the next reader does not re-derive it from `workbar-boundary.test.ts`.
jackwener
left a comment
There was a problem hiding this comment.
I found no P0–P3 issues on exact head 994aa9199c10482494046feb591c79aab5ea5e49.
The README now names the three public entries that the code already has: features/workbar, features/workbar/testing, and features/workbar/stories. That matches stories.ts, the production barrel (no WorkbarSurface), workbar-host's lazy(() => import('./workbar-surface')), the Storybook imports, and workbar-boundary.test.ts. testing still does not export the surface. The surface and its panels still use extensionless relative specifiers, so they do not belong on the node --test / tsc path.
Docs only. I am not merging. Hosted test was still queued when I posted; this review does not claim CI is green.
Posted by an automated review agent operated by @WAWQAQ. This is not an
independent human review and does not satisfy the committer review required by
CONTRIBUTING.md. A human is accountable for this comment — please push back if
anything here is wrong.
简体中文
精确 head 994aa9199c10482494046feb591c79aab5ea5e49 上我没有发现 P0–P3。
README 现在写的三个入口和代码一致:生产 barrel、testing、stories。WorkbarSurface 不在生产入口,由 workbar-host 的 lazy() 加载;Storybook 从 stories 引入;testing 仍不导出它。表面和工具面板仍用无扩展名相对路径,所以不能进 node --test / tsc 那条线。
这是文档修正,我不合入。发这条时 hosted test 还在排队,这次审查不表示 CI 已绿。
本条评论由 @WAWQAQ 运行的自动化审查程序发出。它不构成 CONTRIBUTING.md
所要求的独立人类审查,也不能替代人类审查。有人类对本条评论负责,如有错误请直接指出。
Doc drift left by #4101.
That PR gave Storybook its own
features/workbar/storiesentry and movedWorkbarSurfaceout oftesting, and taughtworkbar-boundary.test.tsto accept all three entries — but the feature README still told readers that stories sharetesting.This names the three entries and records why the split exists:
storiesstays out of the production barrel becauseworkbar-hostreaches the surface throughlazy(), and out oftestingbecause that entry is loaded bynode --testagainst tsc output, while the surface and its tool panels use extensionless relative specifiers only a bundler resolves. Putting it intestingis what broke CI on #4101's first attempt; the README is where the next person should find that out.Docs only — no code change.