Remove the Jetty 6 pluginManagement entry and the unbuilt archetype-samples tree - #1013
Draft
dchaudhari7177 wants to merge 1 commit into
Draft
Conversation
…amples tree org.mortbay.jetty:maven-jetty-plugin:6.1.26 sat in the root pluginManagement. That is the pre-Eclipse groupId and its last release, from November 2010. Nothing in the build used it. The only reference was archetype-samples/webapp/pom.xml, in a jetty profile, and archetype-samples is not part of the build: it is not among the four module entries, it was excluded from RAT, and its parent is org.apache.maven.archetypes:archetype-samples:2.0-alpha-5-SNAPSHOT, a version that was never released -- so the tree could not build even if someone tried. Remove all three together: the pluginManagement entry, the tree, and the RAT exclude that pointed at it, which would otherwise be left matching nothing. After this, grep finds no remaining reference to archetype-samples, mortbay or jetty anywhere in the repository. The released archetypes live in apache/maven-archetypes, so no generated project inherits any of this. Verified with Maven 3.9.9 and JDK 21: `mvn -N validate` and `mvn -N apache-rat:check` both succeed on the root module, RAT reporting 0 unapproved and 0 unknown across 19 approved licenses. A full reactor `mvn validate` fails identically before and after this change, in enforce-bytecode-version on archetype-common -- a pre-existing failure in my local environment, not something this touches. Closes apache#1012
Member
|
Too hard removal - maybe we can convert samples to somethgin that woudl not use jetty ? |
slachiewicz
marked this pull request as draft
August 21, 2026 20:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1012.
Removes three things that only made sense together:
org.mortbay.jetty:maven-jetty-plugin:6.1.26from the rootpluginManagementarchetype-samples/tree (13 files)<exclude>archetype-samples/**</exclude>RAT entry, which would otherwise match nothingConfirmed the claims before deleting
archetype-samplesis not among the four<module>entries (archetype-models,archetype-common,maven-archetype-plugin,archetype-packaging)org.apache.maven.archetypes:archetype-samples:2.0-alpha-5-SNAPSHOT— never released, so the tree could not build regardlessjetty/mortbayappeared only in the root POM andarchetype-samples/webapp/pom.xmlAfter the change,
git grepover the committed tree finds no remaining reference toarchetype-samples,mortbayorjetty.Verification
Maven 3.9.9, JDK 21:
mvn -N validatemvn -N apache-rat:checkThe RAT run matters here specifically: removing an exclude can newly expose files, and it does not — 0 unapproved.
A full reactor
mvn validatefails inenforce-bytecode-versiononarchetype-common. I checked that against a pristinemasterand it fails identically there, so it is a pre-existing issue in my local environment and not something this PR touches. CI will be the real signal for the full build.Scope note
The released archetypes live in
apache/maven-archetypes, so no generated project inherits any of this. As the issue notes, the only theoretical reach is anything declaring this root POM as a parent, which outside this repository is nobody.