Conversation
hboutemy
requested review from
bmarwell,
khmarbaise,
michael-o and
slawekjaranowski
April 19, 2023 16:12
michael-o
requested changes
Apr 20, 2023
michael-o
self-requested a review
April 21, 2023 07:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this will ease writing another signing plugin using for example sigstore as a signing tool #43
this extracts the collection from the signature from original implementation
maven-gpg-plugin/src/main/java/org/apache/maven/plugins/gpg/GpgSignAttachedMojo.java
Line 129 in 5255080