Upgrade parent to maven-shared-components 49 - #77
Merged
Conversation
The Jenkins shared library now provisions the Maven wrapper into the workspace before building, which writes .mvn/wrapper/maven-wrapper.properties. That file carries no licence header, and the apache-rat 0.13 pinned by parent 34 counts it as unapproved, so the branch build fails with Too many files with unapproved license: 1 Parent 49 brings apache-rat 0.16.1, which does not. Verified locally by generating the wrapper and running the check both ways: parent 34 gives "Unapproved: 1, unknown: 1" naming .mvn/wrapper/maven-wrapper.properties, parent 49 gives "Unapproved: 0". The source changes are spotless from the new parent, applied rather than hand-edited: the licence header moves above the package statement, imports are reordered, and the modern Maven brace and spacing style is applied. The old post-package header blocks are removed so the header is not duplicated. No code changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Aug 4, 2026
|
@slachiewicz The PR can't be associated to a milestone, because there are multiple open milestones. Please add the text "branch: maven-reporting-api-3.x" to the description to the milestone where this PR belongs to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch's Jenkins build is currently failing:
The cause is external to the repository. The ASF shared Jenkins library now provisions the Maven wrapper into the workspace before building (apache/maven-jenkins-lib#22), which writes
.mvn/wrapper/maven-wrapper.properties. That file has no licence header, and the apache-rat 0.13 pinned by parent 34 counts it as unapproved.Verified locally, generating the wrapper exactly as CI does and running the check both ways:
Unapproved: 1, unknown: 1—rat.txtnames.mvn/wrapper/maven-wrapper.propertiesUnapproved: 0, unknown: 0, approved: 15mvnwandmvnw.cmdare fine either way — the wrapper ships those with ASF headers; only the.propertiesfile lacks one.The source changes are spotless from the new parent, applied rather than hand-edited: the licence header moves above the
packagestatement, imports are reordered, and the modern Maven brace/spacing style is applied. I removed the old post-package header blocks so the header is not duplicated — spotless adds the new one at the top but does not remove the old one. There are no code changes.spotless:checkandapache-rat:checkboth pass locally. I could not run the full build here: the branch targets Java 7 and my local JDK is too new (release version 7 not supported); CI builds it on JDK 8/11/17.maven-reporting-impl-3.xis on parent 34 as well and will likely need the same treatment, though its build currently fails earlier on a missingdoxia-sink-api:1.12.0-SNAPSHOT. Context in apache/maven#12676.