Skip to content

Fix null context class loader handling #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Aayush10016 wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix null context class loader handling #105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c506351
Fix null context class loader handling
Aayush10016 Jul 5, 2026
6bb68be
Use system class loader fallback
Aayush10016 Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/org/apache/maven/shared/io/location/ClasspathResourceLocatorStrategy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,9 @@ public ClasspathResourceLocatorStrategy(
public Location resolve(String locationSpecification, MessageHolder messageHolder) {
ClassLoader cloader = Thread.currentThread().getContextClassLoader();

URL resource = cloader.getResource(locationSpecification);
URL resource = cloader != null
? cloader.getResource(locationSpecification)
: ClassLoader.getSystemResource(locationSpecification);

Location location = null;

Expand Down
18 changes: 18 additions & 0 deletions src/test/java/org/apache/maven/shared/io/location/ClasspathResourceLocatorStrategyTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,24 @@ void shouldFailToResolveMissingClasspathResource() {
assertEquals(1, mh.size());
}

@Test
void shouldResolveWithSystemClassLoaderWhenContextClassLoaderIsNull() {
Thread thread = Thread.currentThread();
ClassLoader contextClassLoader = thread.getContextClassLoader();
MessageHolder messageHolder = new DefaultMessageHolder();

try {
thread.setContextClassLoader(null);
Location location =
new ClasspathResourceLocatorStrategy().resolve("META-INF/maven/test.properties", messageHolder);

assertNotNull(location);
assertEquals(0, messageHolder.size());
} finally {
thread.setContextClassLoader(contextClassLoader);
}
}

@Test
void shouldResolveExistingClasspathResourceWithoutPrecedingSlash() {
MessageHolder mh = new DefaultMessageHolder();
Expand Down