fix #84: guard against null wagonManager and null getWagon() - #99
Merged
Conversation
- Check wagonManager for null at start of download() - Check wagon for null after getWagon() - Add tests for both NPE scenarios
elharo
marked this pull request as ready for review
July 5, 2026 12:06
elharo
commented
Jul 5, 2026
|
|
||
| @Test | ||
| void shouldFailToDownloadWhenWagonManagerIsNull() { | ||
| DefaultDownloadManager mgr = new DefaultDownloadManager(); |
Contributor
Author
There was a problem hiding this comment.
mgr --> downloadManager
maximiln
approved these changes
Aug 5, 2026
|
@elharo Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check wagonManager for null at start of download() and check wagon for null after getWagon() to prevent NPEs.
Fixes #84