Fix #136: allow underscores in class names matched by CLASS_FILTER - #155
Open
elharo wants to merge 2 commits into
Open
Fix #136: allow underscores in class names matched by CLASS_FILTER#155elharo wants to merge 2 commits into
elharo wants to merge 2 commits into
Conversation
elharo
added
maintenance
java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #136
Summary
Adds a regression test for #136. The issue reports that
CLASS_FILTERinJarAnalyzerrejects underscores in Java class names (My_Helper.class,some_test.class, etc.).Investigation showed the described behavior does not reproduce:
filterEntriesusesMatcher.find(), so the pattern[A-Za-z0-9]*\\.class$matches any entry ending in.classregardless of what precedes it (the character class only matches the trailing alphanumeric run). No source change is therefore required.Test
Adds
getClassEntriesFindsClassesWithUnderscoresinJarAnalyzerTest, which builds a JAR in memory containing classes with underscores in their names (My_Helper,some_test,UPPER_CASE) alongside a regular class, and asserts all of them are returned bygetClassEntries(). This documents the expected behavior and guards against regressions.