Skip to content

Make CSV importer configurable via ConfigArgParse - #166

Open
MrlixiangWE wants to merge 1 commit into
apache:masterfrom
MrlixiangWE:fix/119-csv-configargparse
Open

Make CSV importer configurable via ConfigArgParse#166
MrlixiangWE wants to merge 1 commit into
apache:masterfrom
MrlixiangWE:fix/119-csv-configargparse

Conversation

@MrlixiangWE

Copy link
Copy Markdown

Problem

CSV is the only importer whose delimiter and quote character cannot be set through ConfigArgParse. They can currently only be configured per test in YAML.

Before / after

Before: CSV delimiter and quote character can only be configured through per-test csv_options in YAML.

After: they can also be set through --csv-delimiter and --csv-quote-char, the matching environment variables, or a csv section in the config file. Explicit global values override per-test options; otherwise existing behavior is unchanged.

Verification

uv run pytest -q --ignore=tests/graphite_e2e_test.py --ignore=tests/postgres_e2e_test.py

uv run tox -e lint

uv build --no-create-gitignore

Closes #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make CSV importer configurable via ConfigArgParse

1 participant