Skip to content

[parquet-thrift] remove pig usage#3377

Open
dossett wants to merge 5 commits intoapache:masterfrom
dossett:gh-3376
Open

[parquet-thrift] remove pig usage#3377
dossett wants to merge 5 commits intoapache:masterfrom
dossett:gh-3376

Conversation

@dossett
Copy link
Copy Markdown
Contributor

@dossett dossett commented Dec 29, 2025

Closes #3376

Removes deprecated parquet-pig functionality

@dossett
Copy link
Copy Markdown
Contributor Author

dossett commented Dec 29, 2025

The maven verify step is failing, but I think that's ok. It's detecting the removal of functionality (i.e. a breaking change), which is the goal.

Fokko
Fokko approved these changes Jan 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dossett this looks great!

Comment thread parquet-thrift/src/main/java/org/apache/parquet/thrift/struct/ThriftType.java
/**
* @deprecated will be removed in 2.0.0; use StateVisitor instead.
*/
@Deprecated
Copy link
Copy Markdown
Contributor

@Fokko Fokko Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Fokko
Copy link
Copy Markdown
Contributor

Fokko commented Jan 13, 2026

@dossett Can you pull in main once more?

Fokko
Fokko reviewed Jan 13, 2026
View reviewed changes
Comment thread README.md

* Type-specific encoding
* Hive integration (deprecated)
* Pig integration (deprecated)
Copy link
Copy Markdown
Contributor

@Fokko Fokko Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically, we leave this in. For example, cascading below has been removed for ages, but is still in the list for historical reasons.

Copy link
Copy Markdown
Contributor Author

@dossett dossett Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I put that back.

julienledem
julienledem approved these changes Jan 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@julienledem julienledem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing this old functionality.
(personally observing a minute of silence).

@dossett
Copy link
Copy Markdown
Contributor Author

dossett commented Jan 13, 2026

@dossett Can you pull in main once more?

Rebased and repushed.

@Fokko
Copy link
Copy Markdown
Contributor

Fokko commented Mar 9, 2026

@dossett Can you fix the API issue? I think we can just ignore it

@dossett
Copy link
Copy Markdown
Contributor Author

dossett commented Mar 9, 2026

@Fokko I think I got it.

@Fokko Fokko mentioned this pull request Mar 10, 2026
Closed
@wgtmac
Copy link
Copy Markdown
Member

wgtmac commented Apr 20, 2026

Could you please resolve the conflict?

@dossett
Copy link
Copy Markdown
Contributor Author

dossett commented Apr 20, 2026

@wgtmac Fixed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fokko Fokko Fokko approved these changes

@julienledem julienledem julienledem approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

parquet-thrift should remove usages of parquet-pig and Apache Pig

4 participants

@dossett @Fokko @wgtmac @julienledem