feat(collection): added alias management#159
Open
y-luis-rojo wants to merge 4 commits into
Open
Conversation
adityamparikh
left a comment
adityamparikh
left a comment
Contributor
There was a problem hiding this comment.
Thanks @y-luis-rojo for the contribution. Seems like a useful capability to add.
Added inline comments as well as overall comments to address:
- Looks like the happy path in unit tests need actual assertions.
- Please add an AliasServiceIntegrationTest that uses Testcontainers to test adding, updating, removing aliases on a new or existing collection.
- Please update the docs with this new tool.
create-alias destructive and idempotent. Added tests. Updated documentation.
Author
Thanks for the comments. I think all are now addressed. |
Contributor
|
An end to end integration tests |
Author
Sorry, missed to add it. Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(collection): add alias management tools (list, create, delete)