PKIAuthenticationPlugin: handle non-base64 SolrAuthV2 signature#4553
Open
janhoy wants to merge 2 commits into
Open
PKIAuthenticationPlugin: handle non-base64 SolrAuthV2 signature#4553janhoy wants to merge 2 commits into
janhoy wants to merge 2 commits into
Conversation
…fully Wrap the base64 decode of the signature token in decipherHeaderV2 in a try/catch so a malformed (non-base64) value returns null and results in a generic 401, instead of propagating an IllegalArgumentException that surfaces as a 500. Mirrors the existing NumberFormatException handling for the timestamp parsing. Adds a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap the base64 decode of the signature token in decipherHeaderV2 in a try/catch so a malformed (non-base64) value returns null and results in a generic 401, instead of propagating an IllegalArgumentException that surfaces as a 500.