-
Notifications
You must be signed in to change notification settings - Fork 841
Overhaul Apache RAT #4569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dsmiley
wants to merge
2
commits into
apache:main
Choose a base branch
from
dsmiley:rat-overhaul
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+217
−178
Open
Overhaul Apache RAT #4569
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!-- | ||
| Licensed to the Apache Software Foundation (ASF) under one or more | ||
| contributor license agreements. See the NOTICE file distributed with | ||
| this work for additional information regarding copyright ownership. | ||
| The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| (the "License"); you may not use this file except in compliance with | ||
| the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
|
|
||
| <!-- | ||
| Custom RAT license families supplementing the built-in defaults. | ||
| --> | ||
| <rat-config> | ||
| <families> | ||
| <family id="MIT" name="The MIT License"/> | ||
| <family id="BSD4" name="Original BSD License (with advertising clause)"/> | ||
| <family id="BSD-modi" name="Modified BSD License"/> | ||
| <family id="GEN" name="Generated"/> | ||
| </families> | ||
|
|
||
| <licenses> | ||
| <!-- BSD 4-clause: presence of advertising clause is a policy violation --> | ||
| <license family="BSD4" id="BSD4" name="BSD 4-Clause (advertising clause)"> | ||
| <text>All advertising materials</text> | ||
| </license> | ||
|
|
||
| <!-- Various BSD-like third-party libraries with non-standard copyright headers --> | ||
| <license family="BSD-modi" id="BSD-modi" name="Modified BSD License"> | ||
| <any> | ||
| <text>THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS</text> <!-- d3.js --> | ||
| <text>THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS</text> <!-- highlight.js --> | ||
| </any> | ||
| </license> | ||
|
|
||
| <!-- Inline MIT comment used by ui-grid bundled assets --> | ||
| <license family="MIT" id="MIT-uigrid" name="MIT (ui-grid)"> | ||
| <text> ; License: MIT</text> | ||
| </license> | ||
|
|
||
| <!-- Machine-generated source files that carry no license header --> | ||
| <license family="GEN" id="GEN" name="Generated"> | ||
| <any> | ||
| <!-- none so far --> | ||
| </any> | ||
| </license> | ||
| </licenses> | ||
|
|
||
| <approved> | ||
| <family license_ref="BSD-modi"/> | ||
| <family license_ref="GEN"/> | ||
| <!-- MIT is already approved by the default config; MIT-uigrid inherits that. --> | ||
| <!-- BSD4 is intentionally absent: matching files are policy violations. --> | ||
| </approved> | ||
| </rat-config> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why include it if there are no rules?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There used to be some but all were old or part of Lucene. I thought it best to leave this here ready to easily add one if needed; it's minor. Of course, we actually do have generated source but I haven't looked at why we don't need this. For some I known we exclude categorically because it's not committed. For committed like a query parser or two, I think it's intermixed with human authored stuff so it gets a license. I think.