SOLR-18296: Upgrade google-java-format to 1.35.0

[serhiy-bzhezytskyy]

https://issues.apache.org/jira/browse/SOLR-18296

Description

Bumps google-java-format from 1.18.1 to 1.35.0. The Java baseline is unchanged (JDK 21); this only affects the spotless code formatter.

google-java-format 1.18.1 calls a javac internal, Log$DeferredDiagnosticHandler.getDiagnostics(), whose signature changed in JDK 24, so gradlew tidy / spotlessApply throws NoSuchMethodError on JDK 24+. 1.34.0+ adds support for newer JDKs; 1.35.0 is the current release.

Changes

• gradle/libs.versions.toml: google-javaformat 1.18.1 -> 1.35.0
• re-ran gradlew tidy: ~35 files reformatted (minor, mechanical — the new formatter version's rules), no logic changes
• spotless (8.3.0) drives the new version with no other change
• changelog entry added under changelog/unreleased/

Testing

gradlew spotlessJavaCheck passes on Eclipse Temurin 21 and on JDK 25.

Notes for reviewers

• Discussed on dev@ before opening (thread: "Upgrading google-java-format (spotless) — fixes JDK 24/25 build break"); no objection (thanks David).

AI assistance disclosure

Per Solr's AGENTS.md / how-to-contribute guidance: this change was prepared with the assistance of an AI coding agent and reviewed by me for correctness, scope, and alignment with Solr's build conventions.

[janhoy]

I think this PR should be split in two commits. One for the toml file and changelog, and another for the 35 reformatted files.

Then add the commit sha for the reformat to .git-blame-ignore-revs. This PR will then be manually pushed, not squashed.

[dsmiley]

I agree with Janhoy. Note that you need not manipulate this PR to "split" it; you can simply put this on hold temporarily and create another PR for the formatting matter. Once that formatting PR merges, then get this PR up to date from main, and add the commit sha janhoy mentions.

[serhiy-bzhezytskyy]

Thanks @janhoy and @dsmiley. I've restructured this into a fresh PR: #4578

• commit 1: the 1.35.0 bump + changelog
• commit 2: the ~35 reformatted files (isolated), added to .git-blame-ignore-revs
• commit 3: the blame-ignore entry

One note on the two-PR suggestion: for a pure formatter version bump the bump
and the reformat can't be separated — each fails spotlessJavaCheck alone (bump
alone → unformatted files; reformat alone → gjf 1.18.1 crashes on JDK 25, which
is the bug this fixes). So I kept them in one PR with the reformat isolated in
its own commit per Jan's suggestion, which preserves the blame-ignore SHA.

Closing this in favour of #4578.