SOLR-18296: dependency-analysis (DAGP) — reporting + safe advice (part 1/3)#4612
Open
serhiy-bzhezytskyy wants to merge 2 commits into
Open
SOLR-18296: dependency-analysis (DAGP) — reporting + safe advice (part 1/3)#4612serhiy-bzhezytskyy wants to merge 2 commits into
serhiy-bzhezytskyy wants to merge 2 commits into
Conversation
Completes the dependency-analysis follow-up deferred from the Gradle 9 upgrade (SOLR-18289), which dropped the Gradle-9-incompatible ca.cutterslade.analyze plugin. Adds the Dependency Analysis Gradle Plugin (com.autonomousapps build-health) configured to REPORT (warn), not fail — its advice is guidance for human review, not enforcement. Applies only the uncontroversial advice: - removal of genuinely-unused dependency declarations - a few test-scope corrections (implementation -> testImplementation) Deliberately NOT included here (left for separate case-by-case review): - implementation -> api promotions (DAGP is aggressive here; per dev@ these need human judgement, as liberal api is viral/transitive) Also forces kotlin-metadata-jvm to match Solr's Kotlin so DAGP can analyze the :solr:ui (Compose/KMP) module. Lockfiles regenerated.
github-actions
Bot
added
documentation
This was referenced Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the dependency-analysis follow-up deferred from the Gradle 9 upgrade (SOLR-18289), which dropped the Gradle-9-incompatible
ca.cutterslade.analyzeplugin.This is part 1 of 3, split so each layer can be judged independently (per @dsmiley / @janhoy dev@ feedback that the api-vs-implementation advice needs human judgement, not blanket application):
project(...)api promotions that are genuinely public API.implementation.This PR's changes
com.autonomousapps.build-healthplugin;dependencyAnalysis {}config set toseverity('warn')(DAGP's default posture — reports advice, never fails the build).implementation -> testImplementationcorrections.testImplementation(DAGP advises testRuntimeOnly, but tests compile against mock-oauth2-server's@JsonDeserializeannotations — demoting breaks compilation under -Werror); documented inline.kotlin-metadata-jvmto match Solr's Kotlin so DAGP can analyze:solr:ui(Compose/KMP) — DAGP doesn't yet support Kotlin 2.4.0 metadata (Update kotlin-metadata-jvm to 2.3+ for Kotlin 2.4 support autonomousapps/dependency-analysis-gradle-plugin#1661); temporary until their fix ships.Testing
gradlew check -x testpasses.AI assistance disclosure
Per AGENTS.md / how-to-contribute.adoc: prepared with an AI coding agent and reviewed by me for correctness, scope, and alignment with Solr's build conventions.