[SPARK-58557][ML] Reuse ML vector data type singleton - #57757
Open
zhengruifeng wants to merge 1 commit into
Open
[SPARK-58557][ML] Reuse ML vector data type singleton#57757zhengruifeng wants to merge 1 commit into
zhengruifeng wants to merge 1 commit into
Conversation
zhengruifeng
changed the title
zhengruifeng
changed the title
zhengruifeng
changed the title
zhengruifeng
changed the title
zhengruifeng
marked this pull request as ready for review
August 4, 2026 12:56
HyukjinKwon
approved these changes
Aug 4, 2026
uros-b
approved these changes
Aug 4, 2026
Member
|
Thank you @zhengruifeng and @HyukjinKwon! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This draft reuses
SQLDataTypes.VectorTypeinstead of creating equivalentVectorUDTinstances throughout the ML implementation.Why are the changes needed?
VectorUDTis stateless. Reusing the canonical ML vector data type avoids repeated equivalent allocations and keeps schema checks and output schemas consistent.Does this PR introduce any user-facing change?
No.
How was this patch tested?
build/sbt mllib/compilecompleted successfully. The test suite was not run.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-5)