[WIP][ML] Avoid duplicate StringIndexer skip lookups - #57761
Draft
zhengruifeng wants to merge 5 commits into
Draft
[WIP][ML] Avoid duplicate StringIndexer skip lookups#57761zhengruifeng wants to merge 5 commits into
zhengruifeng wants to merge 5 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This draft changes the
StringIndexerModelhandleInvalid = "skip"path to produce a nullable index in the existing indexing UDF, then drop rows with null generated indexes. It removes the separate membership-filter UDF.Why are the changes needed?
Previously, every valid label was probed once by
OpenHashMap.containsduring filtering and again byOpenHashMap.getduring indexing. The new plan evaluates one lookup per input label while preserving the existing skip behavior.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added multi-column coverage for unseen and null labels with
handleInvalid = "skip".build/sbt mllib/Test/compilecompleted successfully. The test suite was not run.Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-5)