Skip to content

chore(deps): drop redundant wheel pin from requirements.txt#4860

Merged
Yicong-Huang merged 7 commits intoapache:mainfrom
mengw15:meng-upgrade-wheel
May 8, 2026
Merged

chore(deps): drop redundant wheel pin from requirements.txt#4860
Yicong-Huang merged 7 commits intoapache:mainfrom
mengw15:meng-upgrade-wheel

Conversation

@mengw15
Copy link
Copy Markdown
Contributor

@mengw15 mengw15 commented May 3, 2026

What changes were proposed in this PR?

Remove the wheel==0.41.2 pin from amber/requirements.txt. wheel isn't needed at runtime in either the dev venv or the production image — see #4859 for the rationale. Dropping the pin instead of bumping it.

- wheel==0.41.2

Any related issues, documentation, discussions?

Closes #4859.

How was this PR tested?

Installed requirements.txt (with the wheel pin removed) into a clean venv where wheel was not pre-installed:

python3 -m venv /tmp/test-venv
/tmp/test-venv/bin/pip install --upgrade pip 'setuptools==80.10.2'  # no wheel
/tmp/test-venv/bin/pip install -r amber/requirements.txt -r amber/operator-requirements.txt
/tmp/test-venv/bin/pip check
/tmp/test-venv/bin/python -c "import numpy, pandas, pyarrow, torch, sklearn, transformers, pyiceberg, boto3, s3fs, betterproto, loguru, psutil; print('OK')"

Result: pip check reported No broken requirements found; all imports succeeded. psutil was built from source via PEP 517 build isolation, which pulls wheel into a temporary isolated env automatically — confirming wheel doesn't need to be a runtime dep.

Also tests locally

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude (Anthropic) — used for redundancy analysis and PR description drafting.

@github-actions github-actions Bot added engine dependencies Pull requests that update a dependency file labels May 3, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 42.70%. Comparing base (b4f3a41) to head (bce6623).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4860      +/-   ##
============================================
- Coverage     42.72%   42.70%   -0.03%     
+ Complexity     2185     2184       -1     
============================================
  Files          1031     1032       +1     
  Lines         38152    38161       +9     
  Branches       4004     4006       +2     
============================================
- Hits          16302    16296       -6     
- Misses        20831    20847      +16     
+ Partials       1019     1018       -1     
Flag Coverage Δ *Carryforward flag
access-control-service 39.53% <ø> (ø) Carriedforward from 52915ad
agent-service 33.72% <ø> (ø) Carriedforward from 52915ad
amber 43.17% <ø> (-0.05%) ⬇️ Carriedforward from 52915ad
computing-unit-managing-service 0.00% <ø> (ø) Carriedforward from 52915ad
config-service 0.00% <ø> (ø) Carriedforward from 52915ad
file-service 32.18% <ø> (ø) Carriedforward from 52915ad
frontend 33.08% <ø> (ø) Carriedforward from 52915ad
python 88.82% <ø> (-0.08%) ⬇️
workflow-compiling-service 47.72% <ø> (ø) Carriedforward from 52915ad

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mengw15 mengw15 requested a review from aglinxinyuan May 3, 2026 11:18
@mengw15
Copy link
Copy Markdown
Contributor Author

mengw15 commented May 3, 2026

it seems like wheel is not included in LICENSE-binary-python

@Yicong-Huang
Copy link
Copy Markdown
Contributor

0.47.0 is minor version upgrade. not major version. do we need to include wheel in our requirements.txt?

@Yicong-Huang
Copy link
Copy Markdown
Contributor

0.47.0 is minor version upgrade. not major version. do we need to include wheel in our requirements.txt?

@mengw15 ?

@mengw15
Copy link
Copy Markdown
Contributor Author

mengw15 commented May 4, 2026

0.47.0 is minor version upgrade. not major version. do we need to include wheel in our requirements.txt?

wheel has been in requirements.txt previously — I'm not sure why it was originally included. I can remove it and test to see if anything breaks. Converted this pr to Draft

@github-actions github-actions Bot added python and removed engine labels May 4, 2026
@mengw15 mengw15 marked this pull request as draft May 4, 2026 20:56
@mengw15 mengw15 changed the title chore(deps): bump wheel to 0.47.0 chore(deps): drop redundant wheel pin from requirements.txt May 8, 2026
@mengw15
Copy link
Copy Markdown
Contributor Author

mengw15 commented May 8, 2026

@Yicong-Huang Tested — wheel is redundant in requirements.txt. Modified this pr/issue to drop wheel from requirements.txt

@mengw15 mengw15 marked this pull request as ready for review May 8, 2026 14:56
@Yicong-Huang Yicong-Huang enabled auto-merge (squash) May 8, 2026 15:05
Copy link
Copy Markdown
Contributor

@Yicong-Huang Yicong-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yicong-Huang Yicong-Huang merged commit 6832cfa into apache:main May 8, 2026
22 checks passed
@mengw15 mengw15 deleted the meng-upgrade-wheel branch May 8, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove redundant wheel pin from amber/requirements.txt

4 participants