chore(deps): drop redundant wheel pin from requirements.txt#4860
chore(deps): drop redundant wheel pin from requirements.txt#4860Yicong-Huang merged 7 commits intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4860 +/- ##
============================================
- Coverage 42.72% 42.70% -0.03%
+ Complexity 2185 2184 -1
============================================
Files 1031 1032 +1
Lines 38152 38161 +9
Branches 4004 4006 +2
============================================
- Hits 16302 16296 -6
- Misses 20831 20847 +16
+ Partials 1019 1018 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
it seems like wheel is not included in LICENSE-binary-python |
|
0.47.0 is minor version upgrade. not major version. do we need to include wheel in our requirements.txt? |
@mengw15 ? |
wheel has been in requirements.txt previously — I'm not sure why it was originally included. I can remove it and test to see if anything breaks. Converted this pr to Draft |
|
@Yicong-Huang Tested — wheel is redundant in requirements.txt. Modified this pr/issue to drop wheel from requirements.txt |
What changes were proposed in this PR?
Remove the
wheel==0.41.2pin fromamber/requirements.txt.wheelisn't needed at runtime in either the dev venv or the production image — see #4859 for the rationale. Dropping the pin instead of bumping it.- wheel==0.41.2Any related issues, documentation, discussions?
Closes #4859.
How was this PR tested?
Installed
requirements.txt(with thewheelpin removed) into a clean venv wherewheelwas not pre-installed:Result:
pip checkreportedNo broken requirements found; all imports succeeded.psutilwas built from source via PEP 517 build isolation, which pullswheelinto a temporary isolated env automatically — confirmingwheeldoesn't need to be a runtime dep.Also tests locally
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude (Anthropic) — used for redundancy analysis and PR description drafting.