fix: include port id in materialization reader actor id to fix self-join deadlock#4985
Open
Ma77Ball wants to merge 5 commits intoapache:mainfrom
Open
fix: include port id in materialization reader actor id to fix self-join deadlock#4985Ma77Ball wants to merge 5 commits intoapache:mainfrom
Ma77Ball wants to merge 5 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@Yicong-Huang please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Fixes the Difference operator hanging when one upstream operator (e.g., a single CSV) is wired to both of its input ports.
The bug
InputPortMaterializationReaderThreadper upstream URI.(uri, workerActorId)only.ChannelIdentity→ FIFO sequence numbers and end-of-channel markers cross-routed → one port never drains → Difference hangs.The fix
PortIdentityinto the actor name:MATERIALIZATION_READER_<uri>_port<n>[i]_<workerActorId>.toPortIdthrough the three callers ofgetFromActorIdForInputPortStorage:ResourceAllocator→globalPortId.portId.AssignPortHandler→msg.portId.InputManager→InputPortMaterializationReaderThread(new ctor field)Any related issues, documentation, or discussions?
Closes: #2588
How was this PR tested?
VirtualIdentityUtilsSpec— checks the new ID format and asserts distinct IDs for the same(uri, worker)but different port IDs.ExpansionGreedyScheduleGeneratorSpec— buildscsv → differencewith both inputs from the same csv; assertslevelSets.size > 1, proving materialization happens and the schedule isn't a deadlocked single-level region.Was this PR authored or co-authored using generative AI tooling?
Co-authored with: Claude Opus 4.7 in compliance with ASF