ci: add /request-review and /unrequest-review comment commands#4986
ci: add /request-review and /unrequest-review comment commands#4986Ma77Ball wants to merge 1 commit intoapache:mainfrom
Conversation
…hor and committers
|
@aglinxinyuan please review. |
Yicong-Huang
left a comment
There was a problem hiding this comment.
LGTM! This should be useful! Left some minor comments
|
|
||
| // Authorize: PR author always, otherwise commenter must hold | ||
| // write/maintain/admin on the repo (i.e. a committer). | ||
| let allowed = commenter === author; |
There was a problem hiding this comment.
I think we can just allow PR authors to use this. Committers can use GitHub UI already.
| // reject the whole atomic call over one bad name. | ||
| const reviewers = []; | ||
| const team_reviewers = []; | ||
| for (const [, h] of match[2].matchAll( |
There was a problem hiding this comment.
Just curious, can we also allow copilot to be requested as reviewer?
Can you try it on this PR? I.e., Use /request-review to request review from @aglinxinyuan. It supposed to work. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4986 +/- ##
=========================================
Coverage 42.72% 42.72%
Complexity 2185 2185
=========================================
Files 1031 1031
Lines 38152 38152
Branches 4004 4004
=========================================
Hits 16302 16302
Misses 20831 20831
Partials 1019 1019
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What changes were proposed in this PR?
Any related issues, documentation, or discussions?
Closes: #4975
How was this PR tested?
Tested on my local fork.
Was this PR authored or co-authored using generative AI tooling?
Co-Authored with Claude Opus 4.7 in Compliance with ASF