TEZ-4688 TEZ-4648: Tez upgrade to Hadoop 3.5.0 and jersey 2.x#474
Open
maheshrajus wants to merge 7 commits intoapache:masterfrom
Open
TEZ-4688 TEZ-4648: Tez upgrade to Hadoop 3.5.0 and jersey 2.x#474maheshrajus wants to merge 7 commits intoapache:masterfrom
maheshrajus wants to merge 7 commits intoapache:masterfrom
Conversation
Contributor
|
FYI, |
This comment was marked as outdated.
This comment was marked as outdated.
maheshrajus
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
maheshrajus
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@abstractdog @ayushtkn Can you please review and provide comments if any. Thanks ! |
Contributor
|
@maheshrajus , can you please rebase this PR and resolve merge conflicts? |
Contributor
Author
|
@Aggarwal-Raghav Hi, i rebased and pushed the commit just now. Could you please take a look at this? Thanks ! |
| return ReflectionUtils.createClazzInstance(authenticatorClazzName); | ||
| } | ||
|
|
||
| private static class TokenAuthenticatedURLConnectionFactory implements HttpURLConnectionFactory { |
Contributor
There was a problem hiding this comment.
Why TokenAuthenticatedURLConnectionFactory was removed won't it break things on Hadoop delegation token auth?
Contributor
Author
There was a problem hiding this comment.
I checked and added Hadoop delegation token auth related checks in latest commit. Please check and let me know if any other scenarios we can cover. thanks !
| private Client getHttpClient() { | ||
| if (httpClient == null) { | ||
| ClientConfig config = new DefaultClientConfig(JSONRootElementProvider.App.class); | ||
| HttpURLConnectionFactory urlFactory = new PseudoAuthenticatedURLConnectionFactory(); |
Contributor
There was a problem hiding this comment.
If it was removed because HttpURLConnectionFactory was in jersey 1.x, Can we use HttpUrlConnectorProvider ?
Contributor
Author
There was a problem hiding this comment.
@Aggarwal-Raghav PseudoAuthenticatedURLConnectionFactory removed in Jersey 2.x and for Pseudo auth strategy for env where delegation token is not supported (hadoop 2.4). So creating client as per below code will be sufficient in my opinion. Please let me know if anything we can check add over here.
return ClientBuilder.newClient();
Contributor
|
The explicit dependency of |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
@Aggarwal-Raghav Better this we will handle separately. thanks ! |
|
💔 -1 overall
This message was automatically generated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jersey upgrade changes taken from PR : #429 by @abstractdog as they need for hadoop 3.5.0 upgrade.