Skip to content

TEZ-4712: Class-level SpotBugs exclusions for generated Protobuf classes#489

Open
Aggarwal-Raghav wants to merge 1 commit intoapache:masterfrom
Aggarwal-Raghav:TEZ-4712
Open

TEZ-4712: Class-level SpotBugs exclusions for generated Protobuf classes#489
Aggarwal-Raghav wants to merge 1 commit intoapache:masterfrom
Aggarwal-Raghav:TEZ-4712

Conversation

@Aggarwal-Raghav
Copy link
Copy Markdown
Contributor

@Aggarwal-Raghav Aggarwal-Raghav commented Apr 21, 2026

  1. Consolidate specific SpotBugs exclusions into class-level regex matches in findbugs-exclude.xml files.
  2. Generated code should not be manually modified to fix SpotBugs warnings.
  3. This change removes redundant rules targeting individual fields (e.g., PARSER, unknownFields) and methods (e.g., maybeForceBuilderInitialization).

@Aggarwal-Raghav
Copy link
Copy Markdown
Contributor Author

Once this is merge, will add the rule as part of TEZ-4708 to

<Match>
    <Class name="~org\.apache\.tez\.runtime\.internals\.protocolPB\.TezTaskUmbilicalProtocolProtos.*" />
</Match>

which is causing lot of spotbugs verbose alarms.

@tez-yetus
Copy link
Copy Markdown

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 13m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 xmllint 0m 0s xmllint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ master Compile Tests _
+0 🆗 mvndep 0m 34s Maven dependency ordering for branch
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 codespell 0m 8s No new issues.
+1 💚 blanks 0m 0s The patch has no blanks issues.
_ Other Tests _
+1 💚 asflicense 0m 50s The patch does not generate ASF License warnings.
16m 9s
Subsystem Report/Notes
Docker ClientAPI=1.54 ServerAPI=1.54 base: https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-489/1/artifact/out/Dockerfile
GITHUB PR #489
Optional Tests dupname asflicense codespell detsecrets xmllint
uname Linux 43927600ef72 5.15.0-174-generic #184-Ubuntu SMP Fri Mar 13 18:41:50 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-agent/workspace/tez-multibranch_PR-489/src/.yetus/personality.sh
git revision master / 39f2e4c
Max. process+thread count 52 (vs. ulimit of 5500)
modules C: tez-api tez-runtime-internals tez-runtime-library tez-mapreduce tez-dag U: .
Console output https://ci-hadoop.apache.org/job/tez-multibranch/job/PR-489/1/console
versions git=2.43.0 maven=3.9.14 codespell=2.4.1
Powered by Apache Yetus 0.15.1 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants