UNOMI-921: Replace elasticsearch-maven-plugin with Docker-based Elasticsearch in integration tests

[sergehuber]

Stacked PR (merge order)

Role	Branch
Base (merge into)	master
Head (this PR)	UNOMI-itests-es-docker

This PR is stacked: it is the bottom of a chain. Merge into master first; downstream branches that build on top will resync onto the new master tip.

For more information (each PR targets the branch below until the bottom merges): https://github.github.com/gh-stack/introduction/overview/

---

JIRA: https://issues.apache.org/jira/browse/UNOMI-921 — Replace elasticsearch-maven-plugin with Docker-based Elasticsearch Instance in integration tests.

Why this change

The elasticsearch profile in itests/pom.xml currently uses com.github.alexcojocaru:elasticsearch-maven-plugin to download an Elasticsearch tarball and run it as a forked JVM during the Maven build. This approach:

• requires downloading Elasticsearch binaries during the build,
• creates a default_template that overrides user templates on ES 8/9 — currently worked around by BaseIT.fixDefaultTemplateIfNeeded(),
• is inconsistent with the opensearch profile (same itests/pom.xml), which already uses Docker, and
• has a more complex lifecycle to manage.

Aligning Elasticsearch on the same Docker-based approach the opensearch profile uses removes the template-override workaround, eliminates the binary download, and makes both search-engine profiles symmetric.

What changed

itests/pom.xml — elasticsearch profile

• Add <elasticsearch.port>9400</elasticsearch.port> and surface it to Failsafe via systemPropertyVariables, so tests resolve the HTTP port from a single property (value unchanged: 9400).
• Replace the elasticsearch-maven-plugin execution with an io.fabric8:docker-maven-plugin execution running:
  • Image: docker.elastic.co/elasticsearch/elasticsearch:${elasticsearch.test.version}
  • Port mapping: container 9200 → host 9400
  • Heap: -Xms8g -Xmx8g — aligned with OpenSearch and the ES 9 sizing guidance (was 4g)
  • Settings: discovery.type=single-node, cluster.default.index.settings.number_of_replicas=0, xpack.ml.enabled=false, xpack.security.enabled=false, cluster.routing.allocation.disk.threshold_enabled=false, path.repo=/tmp/snapshots_repository
  • Volume bind: ${project.build.directory}/snapshots_repository → /tmp/snapshots_repository
  • HTTP wait probe before the integration-test phase
• Container lifecycle matches the OpenSearch profile exactly: pre-integration-test runs stop + remove (idempotent cleanup) then start with showLogs; post-integration-test runs stop only — the container is kept around (not removed) so logs can be inspected after a failed run.
• Add chmod -R ugo+rwx on target/snapshots_repository in the antrun unzip step. The official ES image runs as UID 1000, so on Linux CI the bind-mounted snapshot repository otherwise hits access_denied during repository verify operations.

pom.xml (root)

• Declare <docker-maven-plugin.version>0.48.0</docker-maven-plugin.version> and add the corresponding <pluginManagement> entry so the elasticsearch profile (and any future user of the plugin) inherits a single version.

Verification

• mvn -P integration-tests,elasticsearch -DskipITs=false verify on itests: container starts on 9400, all integration tests run against it, container is stopped (but not removed) after the run.
• Container is visible via docker ps -a --filter name=unomi-itests-elasticsearch after the run; logs accessible via docker logs.

Follow-ups (tracked under the same JIRA)

These items are part of UNOMI-921 but are kept out of this PR to keep the diff strictly limited to the build-infrastructure swap. They will land in a follow-up PR:

• Remove BaseIT.fixDefaultTemplateIfNeeded() and its call in checkSearchEngine() (now dead code under Docker).

• Migrate16xToCurrentVersionIT: replace the hardcoded ES_BASE_URL = "http://localhost:9400" with the dynamic getSearchPort() resolution.

• Drop the comments referring to the elasticsearch-maven-plugin template-override workaround.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

[sergehuber]

Following an additional local review pass, a few more things have been cleaned up in the latest commit:

• stop-opensearch execution added — the OpenSearch profile was missing a post-integration-test stop, so the container would keep running after a test run. Both profiles now stop their container symmetrically after tests.

• --keep-container flag — to make up for losing the "container stays around after a failure" behaviour, both profiles now support it.keepContainer=true (Maven) / --keep-container (build.sh). When set, the post-test stop is skipped so you can inspect logs or run queries manually. The pre-test cleanup still runs unconditionally on the next run.

• ignoreRunningContainers on the pre-start cleanup — added to both profiles so the stop/remove at the start of a run doesn't fail when no leftover container exists (e.g. first-ever run or after a manual cleanup).

• -Dcluster.default.index.settings.number_of_replicas=0 removed from OpenSearch too — the same JVM-property mistake noted by the Copilot review was also present in OPENSEARCH_JAVA_OPTS; cleaned up there as well.

• GraphQLListIT polling resilience — the catch block and null-guard in the keepTrying supplier were removed in an earlier commit; restored them to prevent a transient HTTP error from aborting the poll loop immediately instead of retrying.

• docker-maven-plugin version pin — centralised in root pluginManagement; the Elasticsearch profile inherits it from there. (The OpenSearch profile still has an explicit <version> — leaving that as a follow-up.)