feat(git): issue/PR comment methods on the GitProvider contract#33
Merged
Conversation
Add `listIssueComments` / `createIssueComment` / `updateIssueComment` to
`GitHubClient` (thin REST wrappers over the GitHub issue-comments API — a PR is
an issue for `/repos/{o}/{r}/issues/{n}/comments`), returning a normalized
`IssueCommentSummary` { id, htmlUrl, body }. All three join the
`GitProviderMethod` union, so they become part of the host-agnostic `GitProvider`
contract (`Pick<GitHubClient, GitProviderMethod>`) any alternate host can satisfy.
Additive: no existing method, type, or behaviour changed. This is the write
capability an edition's PR-review write-back — post the review as an idempotent PR
comment (list → find a marker → update, else create) — composes on top of; nothing
in Studio calls it yet.
100% patch coverage (3 new tests in api.test.ts covering URL/method/body/return
for each); git tsc + eslint + knip clean.
E2E coverage (strict mode)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
listIssueComments/createIssueComment/updateIssueCommenttoGitHubClient(thin REST wrappers over the GitHub issue-comments API — a PR is an issue for/repos/{o}/{r}/issues/{n}/comments), returning a normalizedIssueCommentSummary{ id, htmlUrl, body }. All three join theGitProviderMethodunion, so they become part of the host-agnosticGitProvidercontract (Pick<GitHubClient, GitProviderMethod>) any alternate host can satisfy.Additive: no existing method, type, or behaviour changed. This is the write capability an edition's PR-review write-back — post the review as an idempotent PR comment (list → find a marker → update, else create) — composes on top of; nothing in Studio calls it yet.
100% patch coverage (3 new tests in api.test.ts covering URL/method/body/return for each); git tsc + eslint + knip clean.