Skip to content

Add p90 and p99 response time metrics#28

Merged
itssimon merged 3 commits intomainfrom
add-more-response-time-metrics
Apr 22, 2026
Merged

Add p90 and p99 response time metrics#28
itssimon merged 3 commits intomainfrom
add-more-response-time-metrics

Conversation

@itssimon
Copy link
Copy Markdown
Member

@itssimon itssimon commented Apr 22, 2026

Summary by cubic

Add p90 and p99 response time metrics across the CLI, docs, and DuckDB metrics table to improve latency analysis. The CLI now accepts response_time_p90 and response_time_p99 in the metrics list.

  • Migration
    • Existing DuckDB databases are auto-migrated to add response_time_p90 and response_time_p99; no manual steps needed.

Written for commit b9b5c11. Summary will update on new commits.

@itssimon itssimon self-assigned this Apr 22, 2026
@sentry
Copy link
Copy Markdown

sentry Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.25%. Comparing base (0d9cc56) to head (b9b5c11).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   91.23%   91.25%   +0.01%     
==========================================
  Files          12       12              
  Lines        2066     2070       +4     
==========================================
+ Hits         1885     1889       +4     
  Misses        181      181              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/metrics.rs">

<violation number="1" location="src/metrics.rs:31">
P1: This schema change is not backward-compatible for existing DuckDB files: `CREATE TABLE IF NOT EXISTS` won’t add the new columns, so DB writes can fail on upgraded clients.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread src/metrics.rs
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@itssimon itssimon merged commit 3ef466d into main Apr 22, 2026
6 checks passed
@itssimon itssimon deleted the add-more-response-time-metrics branch April 22, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant