fix: label Clear filters for assistive technology - #17
Draft
janicduplessis wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Trails empty-results action was announced only as “Clear filters.” Give it the explicit assistive-technology label “Clear all trail filters” while leaving its visible text and filter-reset behavior unchanged.
Closes #1
Test plan
no-matching-trail, then selected Adirondacks and Hard to exercise all three filter types in the empty-results state.Clear filterstoClear all trail filters.Search trails, All regions and Any level were selected, and the list returned to 200 trails.Before
Accessibility tree:
[button] "Clear filters"After
Accessibility tree:
[button] "Clear all trail filters"