Skip to content

fix: present not-found link as primary action - #21

Draft
janicduplessis wants to merge 1 commit into
mainfrom
@janic/issue-6-not-found-action
Draft

fix: present not-found link as primary action#21
janicduplessis wants to merge 1 commit into
mainfrom
@janic/issue-6-not-found-action

Conversation

@janicduplessis

Copy link
Copy Markdown
Contributor

Description

The not-found recovery link looked like inline text and was easy to overlook. It now uses the existing primary and inverse theme colors with spacing and radius tokens, and exposes an explicit button role and label while preserving its / destination and “Go to trails” copy.

Closes #6

Test plan

  • Opened trailhead:///hackathon-missing-route on the iOS Stim simulator and verified the action changed from StaticText to Button with the label Go to trails.
  • Checked the action in light and dark appearances for readable foreground and background colors.
  • Pressed the action and verified it opened the Trails tab.

Before

Before: Go to trails appears as plain text

After

After: Go to trails appears as a compact primary action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Hackathon demo] Present the not-found navigation as a clear primary action

1 participant