fix: clarify iOS location and motion permission copy - #23
Draft
janicduplessis wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The legacy always-location and motion usage descriptions used generic generated wording. Both now name Trailhead and explain the benefit: keeping a hike recording active in the background and improving tracking with motion activity.
Only
NSLocationAlwaysUsageDescriptionandNSMotionUsageDescriptionchanged. No prebuild or other native configuration change was made.Closes #9
Test plan
plutil -lint.ioschanged, triggering an Xcode rebuild.Trailhead.app/Info.plistand confirmed they match the source.Stim launch summary:
Before
Source plist:
Installed product:
After
Source and installed product:
The prompt screenshots are contextual rather than a visual before/after of either changed string. Apple documents that current iOS uses the unchanged
NSLocationAlwaysAndWhenInUseUsageDescription;NSLocationAlwaysUsageDescriptionis shown only on iOS versions before 11. The app has no motion-permission request in its UI flow, and the simulator does not provide motion activity, so showingNSMotionUsageDescriptionwould require an out-of-scope behavior change.