fix: prevent pace values from displaying 60 seconds - #24
Draft
janicduplessis wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
formatPacefloored the minute value before independently rounding the remaining seconds, so a remainder near 60 could render as4:60. It now rounds the total pace seconds before splitting minutes and seconds, allowing the minute to carry normally without affecting the other formatters.Test plan
node --test src/lib/format.test.mjspasses four cases covering rollover, zero padding, metric and imperial suffixes, and an unchanged normal pace.Gorge Haut des Capson a Stim-owned iOS simulator and verified its average pace on the same card before and after the fix.Before
After
Closes #10