Skip to content

fix: make recording sheet adjustable with accessibility actions - #25

Draft
janicduplessis wants to merge 1 commit into
mainfrom
@janic/issue-8-record-sheet-accessibility
Draft

fix: make recording sheet adjustable with accessibility actions#25
janicduplessis wants to merge 1 commit into
mainfrom
@janic/issue-8-record-sheet-accessibility

Conversation

@janicduplessis

Copy link
Copy Markdown
Contributor

Description

The recording sheet advertised an adjustable role but ignored increment and decrement actions, so assistive-technology users could not change its detent. The grab area now maps increment to expanded and decrement to collapsed using the existing spring values and expanded state. Its current-state label continues to follow the sheet.

Closes #8

Test plan

  • On the Stim-owned iOS simulator, recorded the collapsed grab area as Expand hike stats; the action list was absent and Notes was not visible.
  • Verified the final grab area registers increment and decrement actions, with typed handlers that drive the existing expanded and collapsed spring targets.
  • Verified tap expands and collapses the sheet, pan expands it, Notes becomes visible, and the label changes to Collapse hike stats.
  • agent-device does not expose a standard adjustable-action invocation command, so action registration was verified in the rendered implementation while the shared state transitions were exercised through both touch paths.

Before

The sheet is collapsed with the Expand hike stats label and no Notes field.

Before: collapsed recording sheet

After

The sheet is expanded with the Collapse hike stats label and the Notes field visible.

After: expanded recording sheet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Hackathon demo] Make the recording sheet adjustable with accessibility actions

1 participant