fix: make recording sheet adjustable with accessibility actions - #25
Draft
janicduplessis wants to merge 1 commit into
Draft
fix: make recording sheet adjustable with accessibility actions#25janicduplessis wants to merge 1 commit into
janicduplessis wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The recording sheet advertised an adjustable role but ignored increment and decrement actions, so assistive-technology users could not change its detent. The grab area now maps increment to expanded and decrement to collapsed using the existing spring values and expanded state. Its current-state label continues to follow the sheet.
Closes #8
Test plan
Expand hike stats; the action list was absent andNoteswas not visible.Notesbecomes visible, and the label changes toCollapse hike stats.agent-devicedoes not expose a standard adjustable-action invocation command, so action registration was verified in the rendered implementation while the shared state transitions were exercised through both touch paths.Before
The sheet is collapsed with the
Expand hike statslabel and noNotesfield.After
The sheet is expanded with the
Collapse hike statslabel and theNotesfield visible.