Record timing per dispatch, not per operation - #69
Merged
Conversation
The runtime measures a compile identifier -- a possibly-fused group of Core AI operations -- as a whole, so a duration belongs to the group rather than to any one member. It also reports each encoder twice; only one of the two measurements is kept now, since pooling them put two different quantities in one sample list. - `OperationTiming` carries `op_ids` and one undivided `measurement`, and the summary lists every member rather than a representative, which collided. - `_timings` is keyed on `(odix_id, sorted op ids)`: `delegate_id` is a per-dispatch counter, and an unsorted key split one dispatch across rows. - An untimed warmup iteration, since a first inference is not the steady state. - `operations_by_id` exposes every operation in the function, so a caller can compute coverage on its own terms. - Module timings are filed against the deepest module containing all of a dispatch's operations, and no module reports a total: fusion crosses module boundaries, so a total charges one module for a sibling's work. - Removed `total_duration_ns` and the per-operation lookups, which presented a profiling span and a shared duration as latency and per-operation cost. Adds `timing_diff` for comparing two runs. Op ids are positional, so an edit renumbers them and comparing by id compares unrelated work. `op_id_alignment` supplies the correspondence, and dispatches pair only when they cover the same operations; one that gained or lost operations is reported as resized, with the delta attributable to them, and anything else as present on one side only. Rendering moves onto the shared table and tree writers.
cymbalrush
force-pushed
the
fix/delegate-benchmarking
branch
from
August 26, 2026 17:59
7620faf to
b226718
Compare
gokulkrishna98
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime measures a compile identifier -- a possibly-fused group of Core AI operations -- as a whole, so a duration belongs to the group rather than to any one member. It also reports each encoder twice; only one of the two measurements is kept now, since pooling them put two different quantities in one sample list.
OperationTimingcarriesop_idsand one undividedmeasurement, and the summary lists every member rather than a representative, which collided._timingsis keyed on(odix_id, sorted op ids):delegate_idis a per-dispatch counter, and an unsorted key split one dispatch across rows.operations_by_idexposes every operation in the function, so a caller can compute coverage on its own terms.total_duration_nsand the per-operation lookups, which presented a profiling span and a shared duration as latency and per-operation cost.Adds
timing_difffor comparing two runs. Op ids are positional, so an edit renumbers them and comparing by id compares unrelated work.op_id_alignmentsupplies the correspondence, and dispatches pair only when they cover the same operations; one that gained or lost operations is reported as resized, with the delta attributable to them, and anything else as present on one side only.