Annotate QLog types with @available(Network 0.1.0, *)#25
Merged
Conversation
Building with the `QlogOutput` trait enabled surfaced additional availability errors in `QLog.swift`: the types and final class inside the `#if QlogOutput` block reference `Network 0.1.0` types (`QUICStreamID`, `Packet`, `NetworkClock`, etc.) but were not themselves marked available.
rnro
requested review from
agnosticdev,
kkuk24,
rpaulo and
tfpauly
as code owners
agnosticdev
approved these changes
Jun 17, 2026
tfpauly
approved these changes
Jun 17, 2026
Contributor
|
Shouldn't the CI be building all trait combinations? |
Contributor
Author
That seems like an enhancement we should add, yeah. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building with the
QlogOutputtrait enabled surfaced additional availability errors inQLog.swift: the types and final class inside the#if QlogOutputblock referenceNetwork 0.1.0types (QUICStreamID,Packet,NetworkClock, etc.) but were not themselves marked available.