QUIC: Gate QUICSignpost real implementation on canImport(os)#28
Merged
Conversation
* Add `canImport(os)` to the `#if SignpostOutput` condition so the `OSSignposter`-backed `QUICSignpost` only compiles on platforms that ship Apple's OS signposting APIs. * Drop the dead `#if canImport(Glibc) ... #elseif canImport(os)` import block; the `Glibc`/`Logging` arm imported swift-log symbols that the struct never used. * On non-Apple platforms with the trait enabled, `QUICSignpost` now falls through to the existing `#else` no-op stub instead of failing to compile with "cannot find type 'OSSignpostIntervalState'".
rnro
requested review from
agnosticdev,
kkuk24,
rpaulo and
tfpauly
as code owners
tfpauly
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
canImport(os)to the#if SignpostOutputcondition so theOSSignposter-backedQUICSignpostonly compiles on platforms that ship Apple's OS signposting APIs.#if canImport(Glibc) ... #elseif canImport(os)import block; theGlibc/Loggingarm imported swift-log symbols that the struct never used.QUICSignpostnow falls through to the existing#elseno-op stub instead of failing to compile with "cannot find type 'OSSignpostIntervalState'".