Use developerknowledge-go for documentation API#681
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the Developer Knowledge API client in internal/mycli/statements_llm_tooluse.go and its corresponding tests to use the external github.com/apstndb/developerknowledge-go library. This replaces custom HTTP client logic, rate limiting, retry mechanisms, and JSON unmarshaling with the library's client and types, significantly simplifying the codebase. There are no review comments to evaluate, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Code Metrics Report📊 View detailed coverage report (available for 7 days)
Details | | main (576e32c) | #681 (070ab34) | +/- |
|---------------------|----------------|----------------|-------|
- | Coverage | 70.2% | 70.2% | -0.1% |
| Files | 84 | 84 | 0 |
| Lines | 7517 | 7480 | -37 |
- | Covered | 5281 | 5253 | -28 |
+ | Code to Test Ratio | 1:1.2 | 1:1.2 | +0.0 |
| Code | 17283 | 17214 | -69 |
+ | Test | 22323 | 22335 | +12 |
+ | Test Execution Time | 1m42s | 46s | -56s |Code coverage of files in pull request scope (87.1% → 90.4%)
Reported by octocov |
Summary
Tests