Skip to content

Use developerknowledge-go for documentation API#681

Merged
apstndb merged 2 commits into
mainfrom
use-developerknowledge-go-dkapi
Jun 18, 2026
Merged

Use developerknowledge-go for documentation API#681
apstndb merged 2 commits into
mainfrom
use-developerknowledge-go-dkapi

Conversation

@apstndb

@apstndb apstndb commented Jun 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace the local Developer Knowledge API HTTP/error/retry client with github.com/apstndb/developerknowledge-go v0.1.2
  • use the GA v1 Developer Knowledge document endpoints while keeping spanner-mycli-specific document name normalization, search result formatting, and batch-to-individual fallback behavior
  • update tests for the shared rate-limit error type while preserving the existing three total attempts

Tests

  • make check

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Developer Knowledge API client in internal/mycli/statements_llm_tooluse.go and its corresponding tests to use the external github.com/apstndb/developerknowledge-go library. This replaces custom HTTP client logic, rate limiting, retry mechanisms, and JSON unmarshaling with the library's client and types, significantly simplifying the codebase. There are no review comments to evaluate, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown

Code Metrics Report

📊 View detailed coverage report (available for 7 days)

main (576e32c) #681 (070ab34) +/-
Coverage 70.2% 70.2% -0.1%
Code to Test Ratio 1:1.2 1:1.2 +0.0
Test Execution Time 1m42s 46s -56s
Details
  |                     | main (576e32c) | #681 (070ab34) |  +/-  |
  |---------------------|----------------|----------------|-------|
- | Coverage            |          70.2% |          70.2% | -0.1% |
  |   Files             |             84 |             84 |     0 |
  |   Lines             |           7517 |           7480 |   -37 |
- |   Covered           |           5281 |           5253 |   -28 |
+ | Code to Test Ratio  |          1:1.2 |          1:1.2 |  +0.0 |
  |   Code              |          17283 |          17214 |   -69 |
+ |   Test              |          22323 |          22335 |   +12 |
+ | Test Execution Time |          1m42s |            46s |  -56s |

Code coverage of files in pull request scope (87.1% → 90.4%)

Files Coverage +/- Status
internal/mycli/statements_llm_tooluse.go 90.4% +3.3% modified

Reported by octocov

@apstndb apstndb merged commit 6057104 into main Jun 18, 2026
3 checks passed
@apstndb apstndb deleted the use-developerknowledge-go-dkapi branch June 18, 2026 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant