* main/main_loop.c, man/mlterm.1, etc/main, etc/main.ja, doc/ja/README.ja: Fix hardcoded font size range default descriptions. - #175
Open
sporteka2 wants to merge 3 commits into
Conversation
The help text said "font size range for GUI configurator [1-100]" but the actual default range is 1-200 when USE_FREETYPE is enabled and 1-10000 otherwise. Use conditional compilation to show the correct default.
…rdcoded font size range default descriptions. The man page said the default is 1-10000 and the sample config files said 1-100, while the actual default range is 1-200 when USE_FREETYPE is enabled and 1-10000 otherwise.
sporteka2
changed the title
Owner
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The font size range default was hardcoded in several places with values that don't match the actual default. The actual default range is
1-200whenUSE_FREETYPEis enabled and1-10000otherwise (seeuitoolkit/ui_font_manager.c, lines 76-88).What was wrong
main/main_loop.chelp text (-R/--fsrange)[1-100][1-200](USE_FREETYPE) /[1-10000](otherwise)man/mlterm.1default 1-10000default 1-200(freetype) /1-10000(otherwise)etc/main,etc/main.jasample configsfont_size_range = 1-100font_size_range = 1-200doc/ja/README.ja(*1-10000*)(*1-200*)Changes
main/main_loop.c: Correctfont_size_rangehelp text via conditional compilationman/mlterm.1: Document both default rangesetc/main,etc/main.ja,doc/ja/README.ja: Use the actual default rangeChangeLog: Add entriesVerification
./configure && makecompiles successfullymlterm --helpandman mltermshow the corrected rangesetc/main/etc/main.jaremain valid sample configs