test(irx): cover null and edge cases for compute layer - #111
Open
yogendra-17 wants to merge 20 commits into
Open
test(irx): cover null and edge cases for compute layer#111yogendra-17 wants to merge 20 commits into
yogendra-17 wants to merge 20 commits into
Conversation
…s to prevent overflow errors
…on, and interop capabilities
binary operations, filtering and sorting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request description
#110 added the compute kernels but only tested the happy paths. This adds the missing null, empty, overflow, and type-mismatch tests so we don't regress on them later. Test-only, no source changes:
test_compute.pygoes from 15 to 32 tests.Covers: null-skipping aggregations, all-null/empty columns, float min/max, uint64 sum, filtering with null mask slots, null placement in sort, integer divide-by-zero, and silent int overflow.
How to test these changes
...Pull Request checklists
This PR is a:
About this PR:
Author's checklist:
complexity.
Additional information
Reviewer's checklist
Copy and paste this template for your review's note: