fix: resolve ShellCheck lint failures in CI - #3
Merged
Conversation
# Current problem The Lint workflow has been failing on every push: scripts/dock.sh declares a #!/bin/sh shebang but uses bash-only syntax (function keyword, [[ ]], arrays, declare), so ShellCheck evaluated it against POSIX sh rules and flagged the bash-isms as violations. dotfiles/.zshrc had an unquoted source path and two SC1090 warnings for inherently dynamic source paths. scripts/gdone.zsh is a zsh script, which ShellCheck cannot parse at all (SC1071), failing the job outright. # Proposed solution Correct dock.sh's shebang to #!/bin/bash to match the syntax it actually uses, quote the offending variables in .zshrc and dock.sh, silence the two unavoidable SC1090 false positives with directives, and exclude gdone.zsh from the workflow's ShellCheck scan since the tool doesn't support zsh.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current problem
The Lint workflow has been failing on every push: scripts/dock.sh declares a #!/bin/sh shebang but uses bash-only syntax (function keyword, [[ ]], arrays, declare), so ShellCheck evaluated it against POSIX sh rules and flagged the bash-isms as violations. dotfiles/.zshrc had an unquoted source path and two SC1090 warnings for inherently dynamic source paths. scripts/gdone.zsh is a zsh script, which ShellCheck cannot parse at all (SC1071), failing the job outright.
Proposed solution
Correct dock.sh's shebang to #!/bin/bash to match the syntax it actually uses, quote the offending variables in .zshrc and dock.sh, silence the two unavoidable SC1090 false positives with directives, and exclude gdone.zsh from the workflow's ShellCheck scan since the tool doesn't support zsh.