fix(gateway): wire provider and tools into POST /asap handler - #53
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(gateway): wire provider and tools into POST /asap handler#53cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
handle_asap zeroed asap_server_ctx_t and only set cfg, so inbound task.request envelopes always failed with "server missing cfg or provider". Mirror dispatch.c bootstrap wiring and add integration test. Co-authored-by: esadrianno <esadrianno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Inbound
POST /asaptask.requestenvelopes always failed with HTTP 400 (server missing cfg or provider), so the Phase 4 ASAP gateway endpoint could not dispatch agent tasks at all.Root cause
handle_asapinsrc/gateway/routes.czeroedasap_server_ctx_tand only setcfgfrom the HTTP context. It never populatedproviderortools, unlikehandle_messageindispatch.cwhich correctly usesbootstrap_get_provider()andbootstrap_tool_*().Fix
bootstrap_get_cfg(),bootstrap_get_provider(), and the flattened tool table intoasap_ctxbefore callingasap_server_handle().test_asap_task_requestintegration test that posts a valid envelope and expects HTTP 200 withtask.response.Validation
make test_gateway_http && ./build/test_gateway_http— all tests passed.