fix(dispatch): acquire agent mutex around main-loop agent_run - #54
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(dispatch): acquire agent mutex around main-loop agent_run#54cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
The inbound ASAP HTTP path already calls agent_lock() before agent_run(), but the main channel loop did not, allowing concurrent session/memory access when gateway and channels are both active. Co-authored-by: esadrianno <esadrianno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
When the gateway is enabled alongside Telegram/Discord/WebChat channels, the main loop and inbound ASAP HTTP threads can call
agent_run()concurrently. The HTTP path already usesagent_lock(), but the channel dispatch path did not, causing session/memory races and lost conversation turns.Root cause
Asymmetric mutex usage: only non-main threads acquired
agent_lock()while the main loop calledagent_run()without holding the same mutex.Fix and validation
agent_run()inhandle_message()withagent_lock()/agent_unlock().Validation
src/asap/server.c.