fix(agent): preserve multi-round ReAct tool results in message history - #59
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(agent): preserve multi-round ReAct tool results in message history#59cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Tool result messages pointed into a reusable scratch buffer that was overwritten on each iteration, corrupting prior rounds before the next provider chat. strdup tool outputs and free heap-owned ReAct slots on cleanup. Co-authored-by: esadrianno <esadrianno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
When the ReAct loop ran more than one tool round in a single
agent_run, prior tool-result messages were corrupted before the next providerchat()call. The model received wrong tool outputs, breaking multi-step autonomy (cron + shell, chained tool use, etc.).Root cause
agent_react_loopstored tool results as pointers into a fixedtool_result_bufsscratch slab. Each new iteration overwrote that slab while older message slots still referenced it. A prematurefree(prev_assistant)also freed assistant text still referenced inctx->messages.Fix and validation
strdupeach tool result when appending to the message list.base_msg_countand free heap-owned ReAct slots (assistant text, tool results,tool_calls) inagent_run_cleanup.test_react_loop_preserves_prior_tool_results— fails on main, passes with fix.Validation:
make test_agent— all tests passed (new regression test included).