fix(gateway): reject oversized ASAP responses instead of truncating JSON - #61
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(gateway): reject oversized ASAP responses instead of truncating JSON#61cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: esadrianno <esadrianno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Inbound POST /asap task responses larger than the 64 KiB gateway HTTP buffer were silently truncated while returning HTTP 200, producing invalid JSON-RPC for callers.
Root cause
handle_asap copies the serialized response into RESP_BUF_SIZE (65536) without checking length, while the ASAP agent buffer allows up to 256 KiB.
Fix
Return JSON-RPC -32603 when the serialized response exceeds the gateway buffer instead of truncating mid-payload.