test: map BROWSER_LAUNCH_FAILED to companion HTTP 503 - #11
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Ensure launch failures share the not-installed recovery status path so operators get a consistent 503 + lifecycle code. Co-authored-by: esadrianno <esadrianno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds companion HTTP coverage so
BROWSER_LAUNCH_FAILEDmaps to 503 with the matching lifecycle code (same recovery class as missing browsers).Risky behavior now covered
createSessionthrowingWebchainRuntimeError("BROWSER_LAUNCH_FAILED", …)→ HTTP 503codeandlifecycle.codeareBROWSER_LAUNCH_FAILEDTest files added/updated
services/companion/src/server.test.tsWhy these tests materially reduce regression risk
Operators rely on 503 for browser install/launch recovery. Only
BROWSER_NOT_INSTALLEDwas asserted before; a mapping drift on launch failure would break that recovery signal.How Has This Been Tested?
pnpm --filter @webchain/companion exec vitest run src/server.test.ts(14 passed)