fix(runtime): block session creation during companion shutdown - #12
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(runtime): block session creation during companion shutdown#12cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
BrowserRuntime.shutdown() cleared browserPromise without marking the runtime terminal, so createSession() could relaunch Chromium while the companion was exiting. Close the HTTP server before shutting down the runtime and reject new work once shutdown begins. Co-authored-by: esadrianno <esadrianno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
On SIGTERM/SIGINT (deploy restart, container stop), the companion called
runtime.shutdown()beforeapp.close(). While the HTTP server was still accepting work,shutdown()nulledbrowserPromisewithout marking the runtime terminal, so a concurrent or latecreateSession()could relaunch Chromium. The process then exited viaprocess.exit(0), leaving orphan browser processes and clients holding session IDs for a daemon that was already tearing down.Root cause
BrowserRuntime.shutdown()was not idempotent/terminal — post-shutdowncreateSession()silently relaunched Chromium viagetBrowser().Fix and validation
BrowserRuntimeas shutting down at the start ofshutdown()and reject new session/command work.shutdown()idempotent.Validation:
pnpm --filter @webchain/runtime test— 27 passed (2 new shutdown tests)pnpm --filter @webchain/companion test— 13 passedpnpm lintandpnpm typecheck— green