test: cover companion localhost CORS and OPTIONS preflight - #13
Draft
cursor[bot] wants to merge 1 commit into
Draft
test: cover companion localhost CORS and OPTIONS preflight#13cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Pin allowlist for localhost/127.0.0.1 origins and ensure protected route preflight succeeds without a local token. Co-authored-by: esadrianno <esadrianno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risky behavior now covered
127.0.0.1control-plane origins rejected by companion CORSOPTIONSpreflight on/sessionsand/commandsblocked when nox-webchain-tokenis presentTest files added/updated
services/companion/src/server.test.tsWhy these tests materially reduce regression risk
CORS allowlist + preflight are the gate for every browser→companion call; reject-path was already tested, but allow/preflight regressions would break the local browser loop without failing runtime unit tests.
Validation
pnpm --filter @webchain/companion test(15 tests passed)