fix(runtime): close browser after partial session teardown failures - #15
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(runtime): close browser after partial session teardown failures#15cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Promise.all in shutdown() aborted on the first context.close() error, skipping browser.close() and leaving orphan Chromium processes. Use allSettled with best-effort per-session cleanup and wrap companion SIGTERM/SIGINT handling so app.close() always runs. Co-authored-by: esadrianno <esadrianno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
BrowserRuntime.shutdown()usedPromise.allovercontext.close()calls. When any session context failed to close, the rejection aborted shutdown beforebrowser.close()ran, leaving orphan Chromium/WebKit processes after companion SIGTERM/SIGINT.Root cause
All-or-nothing
Promise.allsemantics inpackages/runtime/src/index.ts, plus companion signal handler that did not guaranteeapp.close()whenruntime.shutdown()threw.Fix and validation
Promise.allSettledwith best-effort per-session cleanup, then always attemptbrowser.close().try/finallyso Fastify always closes.browser.close()when one of two session contexts rejects.pnpm --filter @webchain/runtime test— 26 passed.