test(companion): sessionId correlation on invalid command bodies - #9
Draft
cursor[bot] wants to merge 1 commit into
Draft
test(companion): sessionId correlation on invalid command bodies#9cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Assert lifecycle envelopes keep a present sessionId and omit empty ones when Zod rejects POST /commands payloads. Co-authored-by: esadrianno <esadrianno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends companion HTTP tests so invalid
POST /commandsbodies keeplifecycle.sessionIdwhen present and omit it when empty.Risky behavior now covered
sessionIdis presentsessionIdis not echoed into lifecycle envelopesTest files added/updated
services/companion/src/server.test.tsWhy these tests materially reduce regression risk
Session correlation in error envelopes is part of the companion lifecycle contract used by MCP/clients. Prior coverage only checked invalid bodies without a session id.
Validation
pnpm --filter @webchain/companion exec vitest run src/server.test.ts(15 passed)