Skip to content

Contain static response disconnects at the Node transport boundary - #39

Merged
smiggleworth merged 2 commits into
mainfrom
fix/wobbles
Aug 28, 2026
Merged

Contain static response disconnects at the Node transport boundary#39
smiggleworth merged 2 commits into
mainfrom
fix/wobbles

Conversation

@smiggleworth

@smiggleworth smiggleworth commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #38

The Node static asset adapter now treats client disconnects as transport cancellation, tears down the file source through the pipeline callback, and leaves the server available for later requests. The review fix removes the ineffective synchronous try/catch and handles pipeline errors in the callback.

Public API and compatibility

  • Releases @askrjs/node 0.2.2 from 0.2.1.
  • No public API, peer range, or runtime compatibility contract changes.
  • The lockfile advances only the eligible first-party @askrjs/server patch from 0.2.1 to published 0.2.2.
  • @types/node 26.4.0 is excluded to retain the required 26.3.x line. No major or minor dependency changes, aliases, workarounds, or security work are included.

Validation

  • Clean npm ci: 108 packages, 0 vulnerabilities.
  • The real Node HTTP disconnect regression passed three consecutive focused runs.
  • Full npm run check passed: 3 test files / 63 tests, type checks, build, publint, and packed-artifact validation.
  • Hosted CI passed on Ubuntu, macOS, and Windows for e417b1b.
  • The complete main-to-head diff received a second review after remediation.
  • The only review thread is answered and resolved; local HEAD, upstream, and PR head match.

Comment thread src/serve.ts Outdated
@smiggleworth
smiggleworth marked this pull request as ready for review August 28, 2026 16:42
Copilot AI lite review requested due to automatic review settings August 28, 2026 16:42
@smiggleworth
smiggleworth merged commit 36e782f into main Aug 28, 2026
3 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client disconnect during static asset delivery can terminate the Node server

2 participants