fix(data): recover queries after scheduler cancellation or rejection - #397
Merged
Conversation
smiggleworth
force-pushed
the
fix/query-work-admission
branch
from
September 6, 2026 20:29
ea14760 to
4050f36
Compare
smiggleworth
force-pushed
the
fix/query-work-admission
branch
from
September 6, 2026 20:40
4050f36 to
8a82cd7
Compare
smiggleworth
marked this pull request as ready for review
September 6, 2026 20:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clearing or rejecting a queued query previously left its refresh promise pending and prevented future refreshes from starting. Query starts now own a cancellable scheduling ticket that settles the current promise and releases queued ownership, including invalidation replacements and reconciliation retries. Existing generation tokens prevent obsolete queued work from settling a newer request.
The ticket's cancellation extension only resets internal bookkeeping and resolves a promise; scheduler clearing does not invoke subscribers. The redundant query
startQueuedflag is removed. Public signatures are preserved, including a Promise return when production admission silently rejects a promoted manual refresh.Validation:
Cancellation limitation: clearing queued work preserves the last published query snapshot. If invalidation already aborted an in-flight request, that snapshot can still report
refreshinguntil a later explicit refresh. This is documented and tested; cancellation does not publish a state change from inside scheduler queue clearing.