fix: bind hydration listener staging to commit authority - #399
Merged
Conversation
smiggleworth
force-pushed
the
fix/hydration-transaction-authority
branch
from
September 6, 2026 20:41
d07be53 to
ee7274a
Compare
smiggleworth
force-pushed
the
fix/hydration-transaction-authority
branch
from
September 6, 2026 21:02
ee7274a to
d46ae5b
Compare
smiggleworth
marked this pull request as ready for review
September 6, 2026 21:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hydration could stage listeners after its coordinator transaction had finished. An open listener child could also publish independently after an enclosing transaction was discarded or joined.
Derive staging eligibility from active commit ancestry, discard abandoned children before opening a fresh scope, and share commit/discard finalization. Reverse listener rollback drains through the existing owned-cleanup helper despite individual failures. Public APIs are unchanged; internal design documentation describes the transaction ownership rules.
Seven focused regressions demonstrated red against the original source and green with the fix. Final rebased head
d46ae5be697f1e392d47e792d6c57f1673498b4dpasses formatting, lint, build, 336 unit, 60 repository, 1639 DOM, 53 browser, public type checks, and 21 packed-consumer tests. The unchanged 256 KiB bundle limit passes. Its source tree matches the independently validated five-fix integration rehearsal.The relevant hydration-listener benchmark passes: 57 samples, mean 31.81 ms, RME 1.01%. This is a validation measurement, not a comparative speedup claim. Hosted CI must pass on this exact head before merge.